Skip to content

fix: fix test.scoped inheritance #7814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

fix: fix test.scoped inheritance #7814

merged 2 commits into from
Apr 9, 2025

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Apr 9, 2025 •
edited
Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Apr 9, 2025 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7a33add
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67f5d7eed335e90008fe8618
😎 Deploy Preview https://deploy-preview-7814--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hi-ogawa
hi-ogawa commented Apr 9, 2025
View reviewed changes
packages/runner/src/suite.ts
Comment on lines +773 to +776
const context = { ...this }
if (scopedFixtures) {
this.fixtures = mergeScopedFixtures(
this.fixtures || [],
context.fixtures = mergeScopedFixtures(
context.fixtures || [],
Copy link
Contributor Author

@hi-ogawa hi-ogawa Apr 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is shared between all extendedTest instance as per fn.apply(context, args) in

vitest/packages/runner/src/utils/chain.ts

Lines 11 to 18 in dee7ce9

export function createChainable<T extends string, Args extends any[], R = any>(
keys: T[],
fn: (this: Record<T, any>, ...args: Args) => R,
): ChainableFunction<T, (...args: Args) => R> {
function create(context: Record<T, any>) {
const chain = function (this: any, ...args: Args) {
return fn.apply(context, args)
}

This was causing extendedTest to track fixtures in a stateful way instead of suite level inheritance. Existing tests were probably relying on that behavior and making inheritance look working.

Now I removed this stateful mutation logic, so proper suite level fixture inheritance is required and that's done via createSuiteCollector's parentCollectorFixtures.

@hi-ogawa hi-ogawa marked this pull request as ready for review April 9, 2025 02:14
@sheremet-va sheremet-va merged commit db6c3bc into vitest-dev:main Apr 9, 2025
12 of 13 checks passed
schogges pushed a commit to kumahq/kuma-gui that referenced this pull request Apr 23, 2025
@dependabot
chore(deps-dev): Bump vitest from 3.1.1 to 3.1.2 (#3781)
ecaab5d 
v3.1.2
   🐞 Bug Fixes
Add global chai variable in vitest/globals (fix: #7474)  -  by @​Jay-Karia in vitest-dev/vitest#7771 and vitest-dev/vitest#7474 (d9297)
Prevent modifying test.exclude when same object passed in coverage.exclude  -  by @​AriPerkkio in vitest-dev/vitest#7774 (c3751)
Fix already hoisted mock  -  by @​hi-ogawa in vitest-dev/vitest#7815 (773b1)
Fix test.scoped inheritance  -  by @​hi-ogawa in vitest-dev/vitest#7814 (db6c3)
Remove pointer-events-none after resizing the left panel  -  by @​alexprudhomme in vitest-dev/vitest#7811 (a7e77)
Default to run mode when stdin is not a TTY  -  by @​kentonv, @​hi-ogawa and @​sheremet-va in vitest-dev/vitest#7673 (6358f)
Use happy-dom/jsdom types for envionmentOptions  -  by @​hi-ogawa in vitest-dev/vitest#7795 (67430)
browser:
Fix transform error before browser server initialization  -  by @​hi-ogawa in vitest-dev/vitest#7783 (5f762)
Fix mocking from outside of root  -  by @​hi-ogawa in vitest-dev/vitest#7789 (03f55)
Scale iframe for non ui case  -  by @​hi-ogawa in vitest-dev/vitest#6512 (c3374)
coverage:
await profiler calls  -  by @​AriPerkkio in vitest-dev/vitest#7763 (795a6)
Expose profiling timers  -  by @​AriPerkkio in vitest-dev/vitest#7820 (5652b)
deps:
Update all non-major dependencies  -  in vitest-dev/vitest#7765 (7c3df)
Update all non-major dependencies  -  in vitest-dev/vitest#7831 (15701)
runner:
Correctly call test hooks and teardown functions  -  by @​sheremet-va in vitest-dev/vitest#7775 (3c00c)
Show stacktrace on test timeout error  -  by @​hi-ogawa in vitest-dev/vitest#7799 (df33b)
ui:
Load panel sizes from storage on initial load  -  by @​userquin in vitest-dev/vitest#7265 (6555d)
vite-node:
Named export should overwrite export all  -  by @​hi-ogawa in vitest-dev/vitest#7846 (5ba0d)
Add ERR_MODULE_NOT_FOUND code error if module cannot be loaded  -  by @​sheremet-va in vitest-dev/vitest#7776 (f9eac)
   🏎 Performance
browser: Improve browser parallelisation  -  by @​sheremet-va in vitest-dev/vitest#7665 (816a5)
@renovate renovate bot mentioned this pull request May 6, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request May 17, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 5, 2025
Merged
1 task
This was referenced Aug 2, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test.scoped() values are not always scoped to the current suite test.scoped() does not cascade to child suites

2 participants

@hi-ogawa @sheremet-va